napalm-automation-community / napalm-panos

NAPALM driver for PAN-OS
Apache License 2.0
29 stars 31 forks source link

In method commit_config, pass all extra kwargs directly to ssh_device commit() method #83

Closed hkam40k closed 2 years ago

hkam40k commented 3 years ago

In method commit_config, pass all extra kwargs directly to ssh_device commit() method in order to expose additional parameters used by netmiko. This permits utilizing useful commit arguments of netmiko such as delay_factor.

itdependsnetworks commented 2 years ago

I do not think this is actually needed, and it would not be compliant with napalm-core's signature/function definition. Let me know if I am missing anything, but closing for now.