napalm-automation-community / napalm-panos

NAPALM driver for PAN-OS
Apache License 2.0
29 stars 31 forks source link

load_replace_candidate broke in v0.5.3 #94

Closed nbtnc1 closed 2 years ago

nbtnc1 commented 2 years ago

Environment

Expected Behavior

Configuration should have loaded on to the device successfully.

Observed Behavior

Error while loading config from {path}.

Steps to Reproduce

  1. Attempt to load a config on to the device using load_replace_candidate

It looks like you removed the else statement from here: https://github.com/napalm-automation-community/napalm-panos/blob/v0.5.3/napalm_panos/panos.py#L206

nbtnc1 commented 2 years ago

Also need an else on the other if too - https://github.com/napalm-automation-community/napalm-panos/blob/develop/napalm_panos/panos.py#L209

itdependsnetworks commented 2 years ago

Will take me a few hours to test, but the logic that was there was a bit complicated, I tried to make it simpler. #97

itdependsnetworks commented 2 years ago

Updated, tested, and released 0.5.4. I yanked 0.5.3 (rather than delete) from pypi.