search

napalm-automation-community / napalm-s350

NAPALM driver for Cisco SMB switches (SF3xx, SF5xx, SG3xx, SG5xx).
Apache License 2.0
16 stars 13 forks source link

Add support for python3 #9

Closed jasperla closed 3 years ago

jasperla commented 4 years ago

The code was already clean, setup.py wasn't advertising it. While here address an incompatability with recent versions of pip.

Closes #6 and #7

cspeidel commented 4 years ago

Hi @jasperla ,

I pushed the pip>=10 fix to the develop branch yesterday, I should have referenced the issue. https://github.com/napalm-automation-community/napalm-s350/commit/cf168a60abfaa963bc1d9a1a8159c78028f96e2d

I'm in the process of switching to tox so it can test 3.6 and 3.7. I've already fixed all the linter errors so pylama passes. I will try to push those to develop soon. Then we can bump the version and merge to master. Sound good?

jasperla commented 4 years ago

@cspeidel Okey, I've rebased to develop. Feel free to pick anything from this PR or discard it if it conflicts with your proposed changes. Bumping the version afterwards sounds like a good idea to me!