napalm-automation-community / napalm-sros

NAPALM driver for Nokia SR OS
Apache License 2.0
17 stars 17 forks source link

Validation of XML config file #28

Closed omron93 closed 3 years ago

omron93 commented 3 years ago

When using this driver to do configuration changes (replace/merge) with xml format, the validity of XML doesn't seem to be checked.

So in case the xml file isn't valid (e.g. missing closing tag) , the driver proceeds with the file, prints no error and hangs. So there is no hint about the provided config file is syntactically incorrect. The issue about function call hanging can be related to #27 .

JonLundstrom commented 3 years ago

We've addressed this under better exception handling and logging enhancements.

JonLundstrom commented 3 years ago

Better exception handling and logging enhancements have been added to provide feedback in this case (invalid XML formatting) and others. Please re-open the issue if this is seen again. Thanks.