napalm-automation-community / napalm-sros

NAPALM driver for Nokia SR OS
Apache License 2.0
17 stars 17 forks source link

No way to disable logging to ./logs-... file #70

Closed omron93 closed 11 months ago

omron93 commented 11 months ago

The init_logging() adds logging to a file in current working directory.

But because the sros napalm driver is loaded "dynamically" from napalm library (get_network_driver() function), it's very hard to disable this logging to file and use different logging setup (e.g. to syslog, or even no logging).

Please add possibility to disable this logging file handler and not changing logging module setting.

jbemmel commented 11 months ago

See https://github.com/napalm-automation-community/napalm-sros/pull/71

There was no need to do custom log configuration, let's remove it

omron93 commented 11 months ago

That's great, exactly what I needed. Thank you @jbemmel