search

napalm-automation-community / napalm-vyos

NAPALM Driver for the VyOS
Apache License 2.0
38 stars 27 forks source link

New feature: commit confirmed #16

Open mirceaulinic opened 7 years ago

mirceaulinic commented 7 years ago

See details in the parent issue napalm-automation/napalm-base#214

mirceaulinic commented 7 years ago

@ppieprzycki would be possible to implement this on VyOS?

ppieprzycki commented 7 years ago

@mirceaulinic Hi, we can try implement this. However it works on vyos a bit differently than eg. on junos. It assumes that rollback method is through restart :)

Where I can find details eg. how optional variable should be named or even better some example for implementation. ?

vagrant@vyos2# commit-confirm commit confirm will be automatically reboot in 10 minutes unless confirmed Proceed? [confirm][y]

vagrant@vyos2# confirm

dbarrosop commented 7 years ago

@ppieprzycki here: https://github.com/napalm-automation/napalm-base/pull/213/files

However, the feature you mention seems something different IMHO. I'd advise to add a huge note in the "caveats" section in the documentation and, also, to lock the feature so it can't be used unless the user has unlocked it (for example, using an optional_arg).