napalm-automation / napalm-ansible

Apache License 2.0
245 stars 103 forks source link

Provide diff as `result.diff` instead of `result.msg` #182

Closed vincentbernat closed 4 years ago

vincentbernat commented 4 years ago

This way, the diff can be automatically displayed when using --diff and the module behaves more like other Ansible modules. Most of the credit for this goes to @fabrepe.

Fix #180

I have documented the change hoping we don't need to continue to put the diff in msg as well (since it would be displayed twice with -v). However, if you feel strongly about this, we could keep it as an undocumented result attribute.

ktbyers commented 4 years ago

Let me see if I can review this by the middle of next week, hopefully.

Regards, Kirk