search

napalm-automation / napalm-base

Apache License 2.0
32 stars 48 forks source link

Enhance `get_arp_table` and `get_mac_address_table` with filtering arguments #217

Open kbirkeland opened 7 years ago

kbirkeland commented 7 years ago

I have to deal with some rather large ARP tables (>20k), so it would be nice to have some filtering built into the API.

I propose the following arguments for get_arp_table:

and the following arguments for get_mac_address_table:

mirceaulinic commented 7 years ago

I am going to approve this request, it makes sense to me. Let's see what @dbarrosop and @ktbyers think about that as well.

ktbyers commented 7 years ago

Yes, I think this is a good idea.

dbarrosop commented 7 years ago

+1

mirceaulinic commented 7 years ago

Hi @kbirkeland - this API change is approved. I have created the issues for each driver. As any API change, we must synchronise all drivers and apply the changed concomitantly. Would you be able to help with this?

Thanks!

kbirkeland commented 7 years ago

Yeah, I can help with this, but I don't have access to a VM for all the driver types. What's the best course of action for those? Just raise NotImplementedError?

mirceaulinic commented 7 years ago

Hi @kbirkeland - no problem about the platforms you don't have, please contribute as much as you are able to. Thanks!