search

napalm-automation / napalm-base

Apache License 2.0
32 stars 48 forks source link

Improvements to uptime string parser #229

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

Fixes bug with with uptime string parser

dbarrosop commented 7 years ago

Would you mind adding some tests here, please?

https://github.com/napalm-automation/napalm-base/blob/develop/test/unit/TestHelpers.py#L45

It's a bit of a shame we haven't done it before.

gjim83 commented 7 years ago

I have some ready in my home laptop but my day got packed today and leaving for a weekend holiday tomorrow morning :) so I can merge my changes into this PR on Monday or Tuesday

ktbyers commented 7 years ago

I will fix test failure shortly.

ktbyers commented 7 years ago

Okay, this should be ready to go. It now has quite a few unit tests

@gjim83 contributed a lot of the work on the unit tests which I incorporated.

dbarrosop commented 7 years ago

+100