search

napalm-automation / napalm-base

Apache License 2.0
32 stars 48 forks source link

Implements #206 #236

Closed narJH27 closed 7 years ago

narJH27 commented 7 years ago

Implements #206

narJH27 commented 7 years ago

@dbarrosop @mirceaulinic Good To merge?

mirceaulinic commented 7 years ago

Hi @narJH27 - we either need to add this to #206, either add the documentation details from #206 here. Anyway, as explained in #206, we cannot merge API changes before implementing the changes in the affected drivers.

mirceaulinic commented 7 years ago

For more info see: https://github.com/napalm-automation/napalm-base/pull/206#issuecomment-279185431 - there are quite a few drivers affected by this change.

narJH27 commented 7 years ago

@mirceaulinic I understand. I will try to get to the other drivers when I can, but I do not have access to a lot of the vendor boxes. So if someone could help out, it would be great!

mirceaulinic commented 7 years ago

Hi @narJH27 - I have moved your commit into https://github.com/napalm-automation/napalm-base/pull/206 as that is the issue tracking the API change. Thanks!