Fix the as_number helper - Githubissues

napalm-automation / napalm-base

Apache License 2.0

32 stars 48 forks source link

Fix the as_number helper #255

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago

confusing variable and function have the same name
fails when the value is already an integer

dbarrosop commented 7 years ago

LGTM but I think it would be great if you could add some unit tests like these: https://github.com/napalm-automation/napalm-base/blob/develop/test/unit/TestHelpers.py#L320

mirceaulinic commented 7 years ago

Right, forgot about tests...