search

napalm-automation / napalm-base

Apache License 2.0
32 stars 48 forks source link

Tests for config under snmp-server (for #277) #279

Closed ogenstad closed 7 years ago

ogenstad commented 7 years ago

An additional test for #277. It's nice that the code knows how to handle the added snmp-server community public RO 10 line correctly.

However it doesn't work for the added snmp-server enable traps entity-sensor as it thinks it's supposed to delete snmp-server enable traps entity.

There will be a number of these scenarios, probably "a lot". In some instances it will also surely differ between various platforms.

ogenstad commented 7 years ago

Adding snmp-server enable traps, to the EXACT_MATCHES list in _can_have_multiple() made it work as expected. Should that list be a common list for all platforms? Perhaps it would be cleaner to move the list to its own file as it grows.