Closed bewing closed 6 years ago
@ktbyers @dbarrosop If you have the spare time to investigate the py3 errors in test_mock_driver, I'd appreciate it, otherwise I'll try to get to it this week/weekend
Try changing this in test_basic()
in test/unit/test_mock_driver.py
From:
with pytest.raises(napalm_base.exceptions.ConnectionClosedException) as excinfo:
d.get_facts()
assert "connection closed" in excinfo.value
To:
with pytest.raises(napalm_base.exceptions.ConnectionClosedException) as excinfo:
d.get_facts()
assert "connection closed" in str(excinfo.value)
Looks like it could be the same for the other errors.
Should we write tests for napalm_base/tests/*, or just omit them from the coverage report?
@bewing I think we should omit them from coverage report.
It's nice to see the last bump to 72% :P
LGTM, @ktbyers any objections?
Let's merge it! :D
Convert napalm_base to tox testing.
py27 tests clean, I don't have py34 installed locally, and the new mock driver fails tests on 3.5 and 3.6.
Will dig into tomorrow.