search

napalm-automation / napalm-base

Apache License 2.0
33 stars 48 forks source link

Fixing issue with PY2 'long' failure in unit test #312

Closed ktbyers closed 6 years ago

ktbyers commented 6 years ago

With the old code if data[key] returned a type long, then correct_class would get set to False here

correct_class = isinstance(data[key], instance_class) and correct_class

And would never be fixed...so unit test would fail on a 32-bit machine.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 61.015% when pulling 4b947047ce06b3641a57ffe91f4efd91a55ed43c on ktbyers:develop2 into e21f10f5f26b02d15ed0e73fe4e6476638d991e7 on napalm-automation:develop.