search

napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

Add VRF support to traceroute and ping on IOS #102

Closed XioNoX closed 7 years ago

XioNoX commented 7 years ago

Cf. https://github.com/napalm-automation/napalm-base/pull/185 for napalm-base.

Tested on IOS-XE.

XioNoX commented 7 years ago

The travis job probably failed because of the missing napalm-base parts (in a different PR).

mirceaulinic commented 7 years ago

Solves https://github.com/napalm-automation/napalm-ios/issues/105

ktbyers commented 7 years ago

This looks good from my perspective once this PR is integrated into napalm-base:

https://github.com/napalm-automation/napalm-base/pull/185

Note, napalm-base has to be fully released to pypi.

Also, we need to update requirements.txt to reflect new required napalm-base version.

mirceaulinic commented 7 years ago

@XioNoX this branch has some lint fixes needed: https://travis-ci.org/napalm-automation/napalm-ios/jobs/193348500 Please next time avoid editing from the browser!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.2%) to 66.135% when pulling 2afdfec2d57a7cf002d2822c29d5d47d38c09fa2 on XioNoX:patch-1 into 527b8d48ce03c78764a6fae2a0fc0d788e17bf37 on napalm-automation:develop.