search

napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

adding conversion to standard mac addr format #110

Closed ebeahan closed 7 years ago

ebeahan commented 7 years ago

Adding conversion and mocked data updates to support addressing https://github.com/napalm-automation/napalm-ios/issues/106

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 65.953% when pulling 48c17cb5dfaf1e45afbfc0c18e15d14f4502e2fb on ebeahan:mac_addr_conversion into 77e837fe75021f6252c7ca8ce3812e2af5716135 on napalm-automation:develop.

mirceaulinic commented 7 years ago

I have raised https://github.com/napalm-automation/napalm-ios/issues/111 to keep tracking of the required changes.

ktbyers commented 7 years ago

@mirceaulinic We probably need some better way to integrate format validation into the unit tests.

In other words, if the format is wrong, unit tests should fail.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 65.953% when pulling 33f2cc8f03e399c191e394abe111bf862a19ff7d on ebeahan:mac_addr_conversion into 77e837fe75021f6252c7ca8ce3812e2af5716135 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 65.953% when pulling 33f2cc8f03e399c191e394abe111bf862a19ff7d on ebeahan:mac_addr_conversion into 77e837fe75021f6252c7ca8ce3812e2af5716135 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 65.953% when pulling 33f2cc8f03e399c191e394abe111bf862a19ff7d on ebeahan:mac_addr_conversion into 77e837fe75021f6252c7ca8ce3812e2af5716135 on napalm-automation:develop.