napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

Inconsistent MAC and IPv6 format for several getters #111

Closed mirceaulinic closed 6 years ago

mirceaulinic commented 7 years ago

Description of Issue/Question

https://github.com/napalm-automation/napalm-ios/pull/110 shows that as of napalm-ios 0.6.0, the following methods need a bit of work and use the ip and mac napalm-base helpers:

napalm-ios version

(Paste verbatim output from pip freeze | grep napalm-ios between quotes below)

0.6.0
ktbyers commented 7 years ago

I can own this part...should improve napalm-base tests such that standardized format for mac-address, IP address is validated as part of unit tests.

dbarrosop commented 7 years ago

should improve napalm-base tests such that standardized format for mac-address, IP address is validated as part of unit tests

I suggest holding a bit on this. Let's discuss it next week. I personally think we should keep the current getters in maintenance mode and focus on OC. The models have builtin type checking so we get a lot of stuff for free.

mirceaulinic commented 6 years ago

Moved to https://github.com/napalm-automation/napalm/issues/451