napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

Issue with show lldp neighbors and long names fixes #103 #115

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

Also fixes #86

ktbyers commented 7 years ago

Needs to be tested on real device by @XioNoX

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 66.098% when pulling 23104e3734b06516603ced5d76fc12c73be3dfb7 on ktbyers:devel into 9e6152cd5bd65b7990a044799d8ec59bd21fad19 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 66.098% when pulling 23104e3734b06516603ced5d76fc12c73be3dfb7 on ktbyers:devel into 9e6152cd5bd65b7990a044799d8ec59bd21fad19 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 66.098% when pulling 23104e3734b06516603ced5d76fc12c73be3dfb7 on ktbyers:devel into 9e6152cd5bd65b7990a044799d8ec59bd21fad19 on napalm-automation:develop.

XioNoX commented 7 years ago

Works fine for me!

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 66.2% when pulling 66a9143c0cc02f4abfa844b382308f11e2448ba9 on ktbyers:devel into 9e6152cd5bd65b7990a044799d8ec59bd21fad19 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 66.2% when pulling 66a9143c0cc02f4abfa844b382308f11e2448ba9 on ktbyers:devel into 9e6152cd5bd65b7990a044799d8ec59bd21fad19 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 66.2% when pulling 66a9143c0cc02f4abfa844b382308f11e2448ba9 on ktbyers:devel into 9e6152cd5bd65b7990a044799d8ec59bd21fad19 on napalm-automation:develop.

ktbyers commented 7 years ago

@mirceaulinic Can you review this second commit also (as there was a separate bug on 'show lldp neighbors' where the capability field was missing). That was a pretty simple fix.

XioNoX commented 7 years ago

2nd commit works as well for me!