telnet/ssh/secret support

napalm-automation / napalm-ios

Apache License 2.0

31 stars 40 forks source link

telnet/ssh/secret support #191

Closed bartdorlandt closed 7 years ago

bartdorlandt commented 7 years ago

telnet/ssh/secret support added telnet support (tested on IOU). Using the transport mechanism already documented here. documentation was therefore already provide, but code was lacking behind. default is still ssh of course.

Also added support for the enable_password / secret. Moved a statement up, to be actually useful.

file: napalm_ios/ios.py

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 70.599% when pulling 28e8e1fadcc54c960ee103fee43fec4a1ce4a79c on bambam82:telnet-secret-support into ebf9c23e4aa86506e7e707621acabf2030719d36 on napalm-automation:develop.

ktbyers commented 7 years ago

@bambam82 Thanks for submitting this.

There is a separate PR on this. See #159 . It is waiting on me...I should be able to get at it in September.

bartdorlandt commented 7 years ago

Hi Krik, thanks for your reply. In this case it is not just telnet, that is indeed covered by #159 . Though, the port isn't made explicit. There are a few other fixes in there as well. In case any help is needed, please let me know when you get to it. Cheers.

ktbyers commented 7 years ago

@bambam82 Everything referenced here is included here:

https://github.com/napalm-automation/napalm-ios/pull/192