search

napalm-automation / napalm-ios

Apache License 2.0
32 stars 40 forks source link

Add telnet support #192

Closed ktbyers closed 6 years ago

ktbyers commented 6 years ago
coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.9%) to 69.745% when pulling f1079cb8b449fc22cd367b0b8b67d634e3f3547e on ktbyers:allow-telnet into ebf9c23e4aa86506e7e707621acabf2030719d36 on napalm-automation:develop.

ktbyers commented 6 years ago

This expands on earlier telnet support PRs mainly fixing is_alive to work with telnet.

I tested telnet connectivity to real device for get_facts. I also tested is_alive() to real device for both SSH and telnet (in both the alive and fail case).

@mirceaulinic I think we should make the is_alive code referenced here the standard for Netmiko (the SSH section of it). Basically, I used a lower level write_channel() for the code which makes more sense given what we are doing.

I also removed some legacy code that checked Netmiko version, but is no longer relevant (since requirements.txt requires a much higher version of Netmiko than what was being checked for).

ktbyers commented 6 years ago

Okay, expanded comment a bit on IAC + NOP meaning.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.9%) to 69.745% when pulling 634948e3786cd30f336858b7f7fa8a11b089d189 on ktbyers:allow-telnet into ebf9c23e4aa86506e7e707621acabf2030719d36 on napalm-automation:develop.

dbarrosop commented 6 years ago

+1