set domain_name value beforehand in get_facts

napalm-automation / napalm-ios

Apache License 2.0

32 stars 40 forks source link

set domain_name value beforehand in get_facts #201

Closed afourmy closed 6 years ago

afourmy commented 6 years ago

in case the "show hosts" command doesn't return anything (empty string), we set domain_name value beforehand This happened on "WS-C3850-24U running 16.3.1"

coveralls commented 6 years ago

Coverage increased (+0.03%) to 69.649% when pulling 57633d48e760728e3f1b7aaf1068795caba451b8 on afourmy:patch-1 into d2870e62bd7c882dfa0aa04129afb80ae577653f on napalm-automation:develop.

coveralls commented 6 years ago

Coverage increased (+2.4%) to 72.06% when pulling 949bf434e3d44b9ff2ac5a0b7a0af542b920d45b on afourmy:patch-1 into d2870e62bd7c882dfa0aa04129afb80ae577653f on napalm-automation:develop.

ktbyers commented 6 years ago

Needs unit test case.

coveralls commented 6 years ago

Coverage increased (+2.4%) to 72.06% when pulling 0fbeb556fe26d1c42372823b1eed4948cc08bb89 on afourmy:patch-1 into d2870e62bd7c882dfa0aa04129afb80ae577653f on napalm-automation:develop.

afourmy commented 6 years ago

I have added a test in the mocked data folder. I haven't looked at how tests work in NAPALM but I guess that's all I need to do and the testIOSDriver will take care of running it. If there's more, please tell me which file I should look into. Thanks

ktbyers commented 6 years ago

@afourmy Does show hosts not return anything because the device doesn't return anything for that command or because of a Netmiko bug?

ktbyers commented 6 years ago

Fixed here:

https://github.com/napalm-automation/napalm-ios/pull/212