search

napalm-automation / napalm-ios

Apache License 2.0
32 stars 40 forks source link

Get interfaces ip #205

Closed targuan closed 6 years ago

targuan commented 6 years ago

Fix #204 As proposed in the issue by ktbyers I used show ip[v6] interface.

I changed the documentation of get_interfaces_ip in the code as N/A was not accepted on link-local ipv6 prefix_length because it was not an integer. I replaced N/A by 64 which seems to be the prefix length of such addresses.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.9%) to 71.797% when pulling 8cdc7c22448b875441aee1fb0ab8d435f7759412 on targuan:get_interfaces_ip into eaaaec6d800ec16717413e255643fc3493df0252 on napalm-automation:develop.

ktbyers commented 6 years ago

FYI, we agreed on /10 for link-local addresses after reviewing some documents on it:

https://github.com/napalm-automation/napalm-base/issues/304

A bit of ambiguity on whether we should use /64 or /10 for this.

ktbyers commented 6 years ago

Only other comment I have is that I need to verify how we handle secondary addresses by default. In other words, whether we do anything to differentiate between a secondary or primary address in the returned data structure.

targuan commented 6 years ago

Thanks for your feebacks. I've updated my PR according to your remarks.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.9%) to 71.797% when pulling d06c7b945a37634d1e847b5c2221d41d3da8ba53 on targuan:get_interfaces_ip into eaaaec6d800ec16717413e255643fc3493df0252 on napalm-automation:develop.

ktbyers commented 6 years ago

The secondary address form is correct. So this should be right.