search

napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

Fix Misc Getter issues #78

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

Fix #74 BGP getters issue with trailing newline and additional terminal messages in output. Fix #77 to support multiple show mac address commands Fix #76 support for static ARP entries Fix #62 support multiple formats for show mac address output

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 65.432% when pulling 7d81c84dfec4156fcd10dfdebce75b67f44bfe0e on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 65.432% when pulling 7d81c84dfec4156fcd10dfdebce75b67f44bfe0e on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

ktbyers commented 7 years ago

I also added a wrapper that would strip out the following lines from the output:

Load for five secs: 1%/0%; one minute: 1%; five minutes: 1%
Time source is NTP, *09:59:40.324 UTC Wed Nov 30 2016
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 65.56% when pulling f4a7d139097368068145846d57ea026bc46fcd45 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 65.56% when pulling f4a7d139097368068145846d57ea026bc46fcd45 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

dbarrosop commented 7 years ago

Could you add this to setup.cfg, please?

[tool:pytest]
addopts = --cov=./ -vs
json_report = report.json
jsonapi = true

I want to be able to see on travis that the old and new test cases are running.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 65.895% when pulling 2178e78a5560d2a5ce191b58502501276e4c5823 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 65.895% when pulling 0397f08caaeeecd988b26d4a61cf0a3d50c06b40 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 65.895% when pulling 26f06c316135e7de44c8d8fa5e8e9fb1090392ab on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 65.895% when pulling 26f06c316135e7de44c8d8fa5e8e9fb1090392ab on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

ktbyers commented 7 years ago

@dbarrosop Okay, added your fix.

ktbyers commented 7 years ago

Fixes issue #77 also.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 65.895% when pulling 8a476267260cb270f514b15d7e6eb6ded5ef0c41 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

ktbyers commented 7 years ago

@ogenstad Okay, command error is fixed.

ktbyers commented 7 years ago

@mirceaulinic @dbarrosop Note, for static ARP entry I have it return a null string for the interface. Is this what we want the behavior to be?

See issue #76

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.7%) to 65.983% when pulling 82dd13e1968825bde772c8ae55f48e354534e742 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.8%) to 66.024% when pulling 04ee26cc0523150d91069b9461cb71ba7d1d3207 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.8%) to 66.024% when pulling 04ee26cc0523150d91069b9461cb71ba7d1d3207 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.8%) to 66.024% when pulling 04ee26cc0523150d91069b9461cb71ba7d1d3207 on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.9%) to 67.209% when pulling 296a39e7112fd91402fa8433ddfbafc120ad4daa on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.9%) to 67.209% when pulling 296a39e7112fd91402fa8433ddfbafc120ad4daa on ktbyers:devel into 26a785d4ac2a30ba9346b60c802444094b97cfb5 on napalm-automation:develop.

dbarrosop commented 7 years ago

+100