Fixes & new small Jinja templates

mirceaulinic commented 7 years ago

coveralls commented 7 years ago

Coverage remained the same at 67.209% when pulling adaac999fb66f0a50660816f1ef1c7047d800cdf on mirceaulinic:JINJA-TPL into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

dbarrosop commented 7 years ago

+1

ktbyers commented 7 years ago

@mirceaulinic Is there something I am supposed to do on this? It looks like David already approved it.

The unit test failures are probably due to changes in napalm-base.

mirceaulinic commented 7 years ago

@ktbyers Only if you could review and check the Cisco syntax

ktbyers commented 7 years ago

Okay, sounds good.

ktbyers commented 7 years ago

@mirceaulinic

delete_ntp_peers.j2 GOOD delete_ntp_servers.j2 GOOD set_hostname.j2 GOOD set_ntp_peers.j2 GOOD set_ntp_servers.j2 GOOD

delete_snmp_config.j2 ISSUES (these need to be changed):

no snmp-server location
no snmp-server contact
no snmp-server chassis-id
no snmp-server community {{ comm_name }}

snmp_config.j2 ISSUES (issues this needs to be changed):

snmp-server community {{ comm_name }} RW
snmp-server community {{ comm_name }} RO

mirceaulinic commented 7 years ago

Thanks @ktbyers! I've pushed the changes: https://github.com/napalm-automation/napalm-ios/pull/81/commits/16bbb79e40b55b5959f9b32a39c6aed701441d4f

coveralls commented 7 years ago

Coverage increased (+1.8%) to 69.037% when pulling 16bbb79e40b55b5959f9b32a39c6aed701441d4f on mirceaulinic:JINJA-TPL into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 69.037% when pulling 16bbb79e40b55b5959f9b32a39c6aed701441d4f on mirceaulinic:JINJA-TPL into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

napalm-automation / napalm-ios

Fixes & new small Jinja templates #81