Rationalize napalm-ios to adhere to napalm-base requirements and add traceroute method

napalm-automation / napalm-ios

Apache License 2.0

31 stars 40 forks source link

Rationalize napalm-ios to adhere to napalm-base requirements and add traceroute method #83

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

This will make some methods to be private.

It will also change the definition of some methods removing optional arguments that I added.

Also add support for traceroute method (I merged an earlier PR from ubajze and updated it to the new testing framework).

coveralls commented 7 years ago

Coverage increased (+0.2%) to 67.445% when pulling 54de3aee8bff87beadbb0bb9fd725ae15cd43bb0 on ktbyers:devel into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 67.445% when pulling 54de3aee8bff87beadbb0bb9fd725ae15cd43bb0 on ktbyers:devel into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 69.037% when pulling 0cf872529697dc4870c3d7ad436d48fca51f0c1a on ktbyers:devel into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 69.037% when pulling 0cf872529697dc4870c3d7ad436d48fca51f0c1a on ktbyers:devel into e68a9b006e2a2378c6a0a8d57381f3b6a321bb4d on napalm-automation:develop.

ktbyers commented 7 years ago

Oooops @mirceaulinic I missed you approving this earlier. I modified it to add/integrate an earlier PR on traceroute.

Please sanity check it...I think you separately had reviewed each PR. I made some minor changes to the traceroute PR.

dbarrosop commented 7 years ago