search

napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

Set & delete users templates #103

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.207% when pulling 5adcbd3f0842e1fefaa509ffdda2b87740064859 on mirceaulinic:USERS-TPL into c1f502eeae2ca64c140a34b02a26a8a1519d63dc on napalm-automation:develop.

pkleanthous-zz commented 7 years ago

Guys, is it a good idea to implement some test for those templates?

mirceaulinic commented 7 years ago

Yes, that's a very good idea indeed! @dbarrosop also suggested that and I will try something next week.

pkleanthous-zz commented 7 years ago

@dbarrosop Do you test those templates to the other drivers? Do you have any guidelines how it can be done?

I can hack a PoC the upcoming days :smile:

dbarrosop commented 7 years ago

@pkleanthous sad truth is we don't have anything formalized yet. I was planning to work on that once we get the OpenConfig POC out there as I thought it would be great if we could translate those to native configuration and I would love to have rigorous testing then. So, feel free to hack something if you have any idea on how to do this : )

pkleanthous-zz commented 7 years ago

@dbarrosop Last weekend, I made a small PoC.

https://github.com/pkleanthous/napalm-junos/tree/develop/test/templates

Just run the test.py it will try to compare the ".expected" config file with the automatically generated one.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.207% when pulling 6bee21b0de3dce639f62ccfcdf41e6d1a6482fe8 on mirceaulinic:USERS-TPL into c1f502eeae2ca64c140a34b02a26a8a1519d63dc on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.207% when pulling 6bee21b0de3dce639f62ccfcdf41e6d1a6482fe8 on mirceaulinic:USERS-TPL into c1f502eeae2ca64c140a34b02a26a8a1519d63dc on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.207% when pulling 6bee21b0de3dce639f62ccfcdf41e6d1a6482fe8 on mirceaulinic:USERS-TPL into c1f502eeae2ca64c140a34b02a26a8a1519d63dc on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.207% when pulling e208d7cf032b696c88d63e182370c628478baff5 on mirceaulinic:USERS-TPL into c1f502eeae2ca64c140a34b02a26a8a1519d63dc on napalm-automation:develop.