napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

Fix #105 #114

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago

While I still have mixed feelings about this, I recall this is the existing behaviour on napalm-nxos: when a feature is not enabled, it returns empty list/dict.

I have also added logs - which will be handled by the higher-level system. If the user does not have a system capable to handle it, there's not a problem it simply won't see the error message from junos-eznc :)

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 85.409% when pulling 6b0e83779669f4e76f7d5e63c4048e4bf623864a on mirceaulinic:FIX-105 into 8158c016a1f6b651a1670e4caef306fdc0e52ee4 on napalm-automation:develop.

dbarrosop commented 7 years ago

+1