Added commit confirm functionality

napalm-automation / napalm-junos

Apache License 2.0

22 stars 42 forks source link

Added commit confirm functionality #127

Open kderynski opened 7 years ago

kderynski commented 7 years ago

Related to napalm-automation/napalm-base#213

kderynski commented 7 years ago

Hey @mirceaulinic,

Yes, I have tested it. commit_config() without additional argument confirmed=0 doesn't change current behaviour.

BTW I will create PR in a few minutes with brief description of this method in documentation.

mirceaulinic commented 7 years ago

Looking at this, I'd like to test the following scenario:

connect using the config_lock optional arg set as False
commit confirmed x minutes
is the config DB still locked?
confirm the commit
is the config DB unlocked?

kderynski commented 7 years ago

@mirceaulinic I have tested proposed scenario and config DB was unlocked during commit confirmed period. I have added small fix and now it works as it should, so config DB is locked when device waits for confirmation.

mirceaulinic commented 7 years ago

Thanks @kderynski