napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

Require junos-eznc>=2.1.3 #159

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago

To make sure we avoid issues like https://github.com/napalm-automation/napalm-junos/issues/152 Solved via https://github.com/Juniper/py-junos-eznc/pull/721 included in junos-eznc 2.1.3.

ktbyers commented 7 years ago

Why are the unit tests failing?

The change looked fine, but we need to fix the unit tests failing.

mirceaulinic commented 7 years ago

That's very strange. it's failing under test_get_lldp_neighbors_detail/normal and

E           IOError: Couldn't find file with mocked data: /home/travis/build/napalm-automation/napalm-junos/test/unit/mocked_data/test_get_lldp_neighbors_detail/normal/get-lldp-interface-neighbors.xml

@dbarrosop any idea why? So bizarre, isn't it?

It is also failing test_get_bgp_neighbors_detail/normal, although it didn't previously... I will check this one tomorrow.

ktbyers commented 7 years ago

@mirceaulinic Yes, I see the last commit failed here:

https://github.com/napalm-automation/napalm-junos/commits/develop

Although the PR it didn't look like it failed? (I looked at it pretty quickly).

mirceaulinic commented 7 years ago

No, it didn't fail... Weird.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.482% when pulling 4fa4c2b2de2296980f2069491020e931fa72d790 on req-pyez-213 into fcbbbc3dbb2b419060ad83d8b2b35d16472c57c6 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.482% when pulling 4fa4c2b2de2296980f2069491020e931fa72d790 on req-pyez-213 into fcbbbc3dbb2b419060ad83d8b2b35d16472c57c6 on develop.