search

napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

`get_bgp_neighbors_detail` emergency fix #164

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago

The peer-fwd-rti has been introduced only in Junos 15

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.501% when pulling a4043eaa0259d347f71968b40264623d66078a9d on junos-15 into 12663f9d4c464f4cdc9f69e6edf0c7c6cd0fa55d on develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.501% when pulling a4043eaa0259d347f71968b40264623d66078a9d on junos-15 into 12663f9d4c464f4cdc9f69e6edf0c7c6cd0fa55d on develop.

dbarrosop commented 7 years ago

Is there a test for this already?

mirceaulinic commented 7 years ago

Yes, there is: https://github.com/napalm-automation/napalm-junos/blob/develop/test/unit/mocked_data/test_get_bgp_neighbors_detail/normal/facts.yml But the version in the facts is 12, while this bug affects junos 13 and 14 only.

dbarrosop commented 7 years ago

Yeah, that was kind of where I wanted to get at. We should add a case for junos 13 with mocked data that tests this is working there.