get_lldp_neighbors_detail rpc fix

[bugdealer]

pull request for #166

[mirceaulinic]

The tests are failing as we need to do some more work on the test cases. Currently we have a test case called "normal" (https://github.com/napalm-automation/napalm-junos/tree/develop/test/unit/mocked_data/test_get_lldp_neighbors_detail/normal), but I would suggest having two different cases:

• normal_ex_fx_j_srx
• normal_m_mx_t

(or anything that makes sense)

Inside each test case, you'd need a simple YAML file having the content:

personality: SWITCH

and

personality: MX

& the mock data suitably provided. Would you be able to do that? Cheers!

[bugdealer]

I'll have a try.

[bugdealer]

Not sure how to deal with J series for there's no 'personality' for J series.

[coveralls]

Coverage increased (+0.1%) to 83.612% when pulling 0a8c9561c6addc85b62c41387ad3017421d4d626 on bugdealer:develop into fe2fb86c047c23c10b7c689b5cad8d805a805b89 on napalm-automation:develop.

[mirceaulinic]

Looks good @bugdealer, thank you!

Not sure how to deal with J series for there's no 'personality' for J series.

I would suggest submitting a PR to https://github.com/Juniper/py-junos-eznc to add it - it's actually surprising it's not covered yet.

[bugdealer]

God...it's time to use autopep8. Python newbie and first pull request, sorry for all these commits.

[mirceaulinic]

No worries @bugdealer - you did great so far.

[coveralls]

Coverage increased (+0.09%) to 83.594% when pulling e91a4d3754eda80e39a0e86e059c123b78921485 on bugdealer:develop into fe2fb86c047c23c10b7c689b5cad8d805a805b89 on napalm-automation:develop.

[coveralls]

Coverage increased (+0.09%) to 83.594% when pulling e91a4d3754eda80e39a0e86e059c123b78921485 on bugdealer:develop into fe2fb86c047c23c10b7c689b5cad8d805a805b89 on napalm-automation:develop.

[mirceaulinic]

Thanks @bugdealer. This will be included in the next release, 0.10.2.