napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

add optional_arg ignore_warning #180

Closed sincerywaing closed 7 years ago

sincerywaing commented 7 years ago

Description of Issue

add ignore_warning as optional_arg to avoid unnecessary crash.

issue #179

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 83.426% when pulling 0959fff8039fe950034a1fd75d4059a5fedb7376 on sincerywaing:179 into 749031c377a93d8e6fe1c0b1570dc55bb8accd18 on napalm-automation:develop.

dbarrosop commented 7 years ago

Great! it's pretty much done, just a minor change. Could you also update the documentation, please? Just a brief note here:

https://github.com/napalm-automation/napalm/blob/develop/docs/support/index.rst#list-of-supported-optional-arguments

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 83.612% when pulling 5e981503a19c3e3ff96b8f0d682d225583bc9e4f on sincerywaing:179 into 749031c377a93d8e6fe1c0b1570dc55bb8accd18 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 83.612% when pulling 1b702cda038457075a5af214e4f1d36b2af8f137 on sincerywaing:179 into 749031c377a93d8e6fe1c0b1570dc55bb8accd18 on napalm-automation:develop.

dbarrosop commented 7 years ago

Great, all green! I will merge when we have settled napalm-automation/napalm/pull/389 :)

Thanks for the PRs!

sincerywaing commented 7 years ago

Thanks David!!! Really excited to contribute!

On 5 Jul 2017, at 2:59 PM, David Barroso notifications@github.com wrote:

Great, all green! I will merge when we have settled napalm-automation/napalm#389 https://github.com/napalm-automation/napalm/pull/389 :)

Thanks for the PRs!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/napalm-automation/napalm-junos/pull/180#issuecomment-313018254, or mute the thread https://github.com/notifications/unsubscribe-auth/AWEFb9iKKJRY3QsnSA2NPyMz3dwV2g-4ks5sKzQzgaJpZM4ON0M0.