BGP neighbors getters: hail for vendor consistency

napalm-automation / napalm-junos

Apache License 2.0

22 stars 42 forks source link

BGP neighbors getters: hail for vendor consistency #193

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago

The peer_fwd_rti field we rely on to identify the RTI is not widely adopted on all Junos platforms, although it has been introduced theoretically beginning with Junos 15. Yay consistency! That means:

we solve #191
the execution will be slower, as we firstly fetch the list of routing instances, then extract the neighbors under each and every instance.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 83.446% when pulling 48edbc63aba861270ec58b6ac3fa4c0487e5d7f4 on mirceaulinic:iss-191 into e6519c6dcde1e502db4b4ddb1d329ece05de7aea on napalm-automation:develop.

dbarrosop commented 7 years ago

Why are you removing a test case?

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 78.353% when pulling 0d02e074915e6e94051381c95b6a133bdf85857b on mirceaulinic:iss-191 into ea10eddc7e4e43167aa8237cdfe9fb6926ac1b9c on napalm-automation:develop.