napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

Support get_mac_address_table() on L2NG switches #203

Closed mirceaulinic closed 6 years ago

mirceaulinic commented 6 years ago

Hi @bkeifer - I had to close https://github.com/napalm-automation/napalm-junos/pull/199 (your branch was very old and there were many conflicts, so I gave up and picked your commits).

I have added four more commits to continue your work:

Let me know if you have any questions, I hope my information will help you in the future. Thanks for your PR, this enhancement will be included in the next release, 0.12.1.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.04%) to 78.804% when pulling 40da0b40812d3e62378e0d2844786c54a2810702 on mirceaulinic:mac-l2ng-switches into 3a73f1b8519a846c960361784ce0295b1c354b3d on napalm-automation:develop.

mirceaulinic commented 6 years ago

@ktbyers @dbarrosop @bkeifer can you review please?

dbarrosop commented 6 years ago

Yay! I didn't have to ask for tests ;)

+1