search

napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

fix advertised_prefix_count when None #210

Closed ckishimo closed 6 years ago

ckishimo commented 6 years ago

I was getting the following error while using get_bgp_neighbors_detail() 

Traceback (most recent call last):
  File "client_junos_bgp2.py", line 25, in <module>
    res = dev.get_bgp_neighbors_detail(neighbor_address='10.92.99.92')
  File "/home/ckishimo/python/napalm-junos/napalm_junos/junos.py", line 1139, in get_bgp_neighbors_detail
    _bgp_iter_core(neighbor_data, instance=instance)
  File "/home/ckishimo/python/napalm-junos/napalm_junos/junos.py", line 1123, in _bgp_iter_core
    neighbor_rib_details[elem[0]] += elem[1]
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

It seems the counter value for advertised_prefix_count was None, the rib_entry was:

('bgp.evpn.0', [('received_prefix_count', 2), ('active_prefix_count', 2), ('accepted_prefix_count', 2), ('suppressed_prefix_count', 0), ('advertised_prefix_count', None)])

However I tested this code with #209 and that PR is fixing this error as well. Just wondering if it's a good idea to merge this one or not

Also issue #178 should be fixed with #209 or with this one. Thanks

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.06%) to 78.676% when pulling b11cfc862be9b9100ddf7de3f275775e361088dd on ckishimo:devel-bgp3 into 4275c95ca9884beebfb6fa6bfc0d8e0496de86bd on napalm-automation:develop.