search

napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

fix removal of cluster key #219

Closed ckishimo closed 7 years ago

ckishimo commented 7 years ago

This fixes the bug created by myself yesterday (sorry!) related to #214. The cluster key should be removed in each group, so it must be done inside the main loop, and not outside. With the current code having 2 internal groups will have the cluster only removed in the last group, but not the others:

{
    "internal": {
        "apply_groups": [], 
        "cluster": null, 
        "description": "", 
        .....
    }, 
    "internal2": {
        "apply_groups": [], 
        "description": "", 
        .....
    }, 
 }
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 78.3% when pulling bde0c4eddfe104c2486c87c9ae25d83fff27fa38 on ckishimo:devel-rr into ab33fbc685ab89750abf541ffd89575fd6b5b3ff on napalm-automation:develop.