Merging develop into master for the new testing framework

napalm-automation / napalm-junos

Apache License 2.0

22 stars 42 forks source link

Merging develop into master for the new testing framework #79

Closed mirceaulinic closed 7 years ago

coveralls commented 7 years ago

Coverage increased (+2.06%) to 86.443% when pulling f88676ac6f46cea43ee3c24d89197acabafde512 on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

dbarrosop commented 7 years ago

Same here, why merge into master without releasing?

coveralls commented 7 years ago

Coverage increased (+2.0%) to 86.337% when pulling bf5ed178d2468d96d5bfeab0bc91aedad9310df1 on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

mirceaulinic commented 7 years ago

Only to reduce the size of the PR when merged, as the testing framework migration is pretty big - but we can leave it open right now and commits pushed into develop will be here as well.

dbarrosop commented 7 years ago

Let's leave it open, when merging devel into master i mostly care about the tests passing anyway. The actual PR validates are done incrementally with each new addition anyway so no need of checking the base code yet again : )

coveralls commented 7 years ago

Coverage increased (+2.0%) to 86.357% when pulling c1300935f52a6a1fd4952499ad22b8d3cac5286b on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

dbarrosop commented 7 years ago

Is this one ready for merge and release?

mirceaulinic commented 7 years ago

Mm not yet - I would like to fix #84 firstly and eventually try an implementation for #81 (if I can't do it today, I'll leave it for next week).

coveralls commented 7 years ago

Coverage increased (+2.0%) to 86.357% when pulling 2fcee2831c1e03c3d7a970884ec45a7e1246e76a on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

dbarrosop commented 7 years ago

Let's merge #89 first.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 86.169% when pulling cef6b23bc267c5dcc4ed09542c99d94b29064ad3 on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 86.169% when pulling cef6b23bc267c5dcc4ed09542c99d94b29064ad3 on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 86.169% when pulling cef6b23bc267c5dcc4ed09542c99d94b29064ad3 on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 86.169% when pulling cef6b23bc267c5dcc4ed09542c99d94b29064ad3 on develop into dd1587d55fa9e7cba0a482c2e023793f45bb0ac2 on master.