Closed pkleanthous-zz closed 7 years ago
Great job @pkleanthous! I think everything is fine but I will leave the approval to @mirceaulinic as he has more experience with this sort of operations in JunOS devices.
Hi @dbarrosop & @mirceaulinic. Thanks for the review.
Just made the requested changes.
fwiw, I tried this pull request with the new validation class/framework (through napalm_validate). Everything worked well!
With a valid destination IP:
'ping': {u'complies': True,
u'extra': [],
u'missing': [],
u'present': {'success': {u'complies': True, u'nested': True}}}}
With an invalid destination IP:
'ping': {u'complies': False,
u'extra': [],
u'missing': ['success'],
u'present': {}}}
This PR aim to provide the implementation of ping() method on Junos Devices.
It follows the guidelines for the method that you can find here: napalm.readthedocs.io
More info about
ping
command at Juniper Documentation