napalm-automation / napalm-junos

Apache License 2.0
22 stars 42 forks source link

Python3 support and enabling TOX #98

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

This doesn't fix all of the Python3 issues, just some of them.

Still more work to do on the others.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.832% when pulling fc1a7d9331000d674d8a784fa315becc2fec02d0 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

ktbyers commented 7 years ago

@ogenstad Can you double check the TOX items?

ktbyers commented 7 years ago

Having test issues...closing for now. Need to research more why failing.

ogenstad commented 7 years ago

@ktbyers don't think tox is related to the failures. By just looking briefly I would guess that this is the issue: https://github.com/napalm-automation/napalm-junos/blob/develop/napalm_junos/junos.py#L1358-L1361 and that the unordered dict returns different data on different runs. So some times the tests are searching for a file which doesn't exist.

get_configformat_textdatabase_candidate.xml instead of get_configdatabase_candidateformat_text.xml

ktbyers commented 7 years ago

@ogenstad Yes, I don't think it is TOX related either.

I am getting different errors on my test server and errors under Python2...so I was going to go sort some of that out and resubmit.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.832% when pulling cab64c89443c77e883b199892966af28c3b37acf on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.832% when pulling cab64c89443c77e883b199892966af28c3b37acf on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

ktbyers commented 7 years ago

@mirceaulinic I fixed the issues I was having with get_config tests and dictionary ordering.

Is this 'blocked' for some other reason?

ktbyers commented 7 years ago

@mirceaulinic @dbarrosop Note, for junos_views.py fix. I think this should really be fixed in PYEZ and submitted an issue there. I implemented the current fix as an interim solution.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 85.422% when pulling e7e4077be14058c4d56b251a5f7bd2362dc855a9 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 85.442% when pulling ff31741255ee9730a32e7af930e7b7182af07450 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 85.442% when pulling 1fb3b4341614d0452b5c15bbdc23bb7b5f47ad22 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 85.87% when pulling 4df9c2fdb66b4f013a2ccd4948fd0872023c28a9 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

ktbyers commented 7 years ago

@mirceaulinic We should also regression test this against real Juniper device.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 85.87% when pulling 1c6d838981cdf8abfac20fe2d5b02d822948a3a0 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 85.85% when pulling 8146a45a42f59c62d86940f92ffd7e1451fcd92b on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.

mirceaulinic commented 7 years ago

Sure @ktbyers - I will do some tests later today.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 86.207% when pulling e4850ef534d8fcf0a3637b29330bafa589389157 on ktbyers:develop into d9515205dcf896957293497c52567994ba64c0a6 on napalm-automation:develop.