Closed ktbyers closed 7 years ago
@ogenstad Can you double check the TOX items?
Having test issues...closing for now. Need to research more why failing.
@ktbyers don't think tox is related to the failures. By just looking briefly I would guess that this is the issue: https://github.com/napalm-automation/napalm-junos/blob/develop/napalm_junos/junos.py#L1358-L1361 and that the unordered dict returns different data on different runs. So some times the tests are searching for a file which doesn't exist.
get_configformat_textdatabase_candidate.xml instead of get_configdatabase_candidateformat_text.xml
@ogenstad Yes, I don't think it is TOX related either.
I am getting different errors on my test server and errors under Python2...so I was going to go sort some of that out and resubmit.
@mirceaulinic I fixed the issues I was having with get_config tests and dictionary ordering.
Is this 'blocked' for some other reason?
@mirceaulinic @dbarrosop Note, for junos_views.py fix. I think this should really be fixed in PYEZ and submitted an issue there. I implemented the current fix as an interim solution.
@mirceaulinic We should also regression test this against real Juniper device.
Sure @ktbyers - I will do some tests later today.
This doesn't fix all of the Python3 issues, just some of them.
Still more work to do on the others.