Fix get_bgp_neighbors hard-coded with is_up: True and is_enabled: True

napalm-automation / napalm-nxos

Apache License 2.0

9 stars 21 forks source link

Fix get_bgp_neighbors hard-coded with is_up: True and is_enabled: True #115

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

Current implementation of get_bgp_neighbors is hard-coded to report is_up and is_enabled as always True...(not happy it was implemented this way).

Also the uptime and prefixes are hard-coded to '-1'. This only fixes the BGP state reporting. I will report separate issue on those.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 68.821% when pulling f5e5e1a8b8c57cac93508b1733e607fbe8eca388 on ktbyers:develop into 8e6cd55f0353f4594aa847d5f378cdcb1f21e5f0 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 68.821% when pulling 313a55efd520ccfbc92d5a4679c17ec75540768e on ktbyers:develop into 8e6cd55f0353f4594aa847d5f378cdcb1f21e5f0 on napalm-automation:develop.

ktbyers commented 7 years ago

Fixed issue with dictionary definition being inside of nested for loops.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 68.821% when pulling 19fda19eea0a235f660dbce6d937038d8eb51c52 on ktbyers:develop into 8e6cd55f0353f4594aa847d5f378cdcb1f21e5f0 on napalm-automation:develop.