napalm-automation / napalm-nxos

Apache License 2.0
9 stars 21 forks source link

Fix #127 get_interfaces_ip fails when multiple ipv6 #135

Open targuan opened 7 years ago

targuan commented 7 years ago

This fix #127 I've deleted the secondary section. I guess this was copied from ipv4 section ? I didn't found a way to configure a secondary on an interface in 7.0.3.I7.1 If I'm mistaken and this is actually possible, could someone add some mocked_data to test it ?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 9a7a35dc0e60a6afe5d0e75298b5ca52af2debc4 on targuan:bugfix/multiple_ipv6 into acdfe1ae17ffaf2bc60235e3b60860b9ef923017 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 9a7a35dc0e60a6afe5d0e75298b5ca52af2debc4 on targuan:bugfix/multiple_ipv6 into acdfe1ae17ffaf2bc60235e3b60860b9ef923017 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 9a7a35dc0e60a6afe5d0e75298b5ca52af2debc4 on targuan:bugfix/multiple_ipv6 into acdfe1ae17ffaf2bc60235e3b60860b9ef923017 on napalm-automation:develop.

ktbyers commented 7 years ago

I think we should just defer this until after reunification and I can re-add or review it then.

ktbyers commented 7 years ago

Will re-implement post-reunification.