search

napalm-automation / napalm-nxos

Apache License 2.0
9 stars 21 forks source link

Fix rollback and cleanup some of the config methods #142

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

I tested the following against an NXOSv device

stage merge, compare_config, commit_config, rollback stage replace, compare_config, commit_config, rollback stage replace, compare_config, discard_config, compare_config (no changes)

Kirk

ktbyers commented 7 years ago

Fixes #141

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling ff15056380052daea12fc31ec8c748d075e62155 on ktbyers:fix_rollback into 289c49bf7863d2ea3a20bc81cd3b3c03605e9d83 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling ff15056380052daea12fc31ec8c748d075e62155 on ktbyers:fix_rollback into 289c49bf7863d2ea3a20bc81cd3b3c03605e9d83 on napalm-automation:develop.

bewing commented 7 years ago

Other than random semantics, LGTM

ktbyers commented 7 years ago

@bewing Brought up the issue of rollback() checkpoint file isn't reusable across time (i.e. it is deleted on close() and is bound to the object a different connection to same device couldn't use it).

Going to discuss this in napalm-council.

ktbyers commented 7 years ago

Created an issue for rollback not persisting across time here:

https://github.com/napalm-automation/napalm-nxos/issues/144