search

napalm-automation / napalm-nxos

Apache License 2.0
9 stars 21 forks source link

Fix file write bug #148

Closed ktbyers closed 7 years ago

ktbyers commented 7 years ago

Current code duplicates the replace file contents due to a file write(). This removes this behavior.

I tested the compare_config, commit, discard_config, rollback operations.

I removed the fix_checkpoint_string() method as I thought writing the file was a bad idea (basically user will have to get checkpoint file properly.

I will duplicate this change in reunification branch.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 4d9838fa93bc3e2882e557b32d059829736856a9 on ktbyers:fix_file_write_bug into fcc3b8b1d08410f5343cec49dcbd24e785cde489 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 4d9838fa93bc3e2882e557b32d059829736856a9 on ktbyers:fix_file_write_bug into fcc3b8b1d08410f5343cec49dcbd24e785cde489 on napalm-automation:develop.

ktbyers commented 7 years ago

Fixes https://github.com/napalm-automation/napalm-nxos/issues/149