search

napalm-automation / napalm-nxos

Apache License 2.0
9 stars 21 forks source link

Traceroute: add vrf arg #71

Closed mirceaulinic closed 7 years ago

mirceaulinic commented 7 years ago

Solves #70

mirceaulinic commented 7 years ago

Weird error, that I'm not seeing in my env: https://travis-ci.org/napalm-automation/napalm-nxos/jobs/199103340

dbarrosop commented 7 years ago

Yeah, I have started to see that one as well. Fixing it is as simple from changing:

try:
    bla
except:
    ble

to:

try:
    bla
except Exception:
    ble
mirceaulinic commented 7 years ago

I have suspected that as well, but I didn't see that chunk of config catching the generic exception. I will double check.

dbarrosop commented 7 years ago

Here: https://github.com/napalm-automation/napalm-nxos/blob/8b4fe0e23da9053c1e5c414f2575c13d1501d5ed/napalm_nxos/nxos.py#L306

mirceaulinic commented 7 years ago

Thanks @dbarrosop

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 67.219% when pulling 6505242e7fd6ac481b41f8793399bbb889bc4f57 on solves-70 into 53721a9570cff342446cf7486b0a04a57a0ce1c7 on develop.