search

napalm-automation / napalm-nxos

Apache License 2.0
9 stars 21 forks source link

Atomic Merge #77

Closed jasmas closed 6 years ago

jasmas commented 7 years ago

Could the merge process be made atomic by taking a snapshot that could be rolled back just before the merge? I thought about writing an enhancement, but I wanted to check here first to see if there is some other technical reason that merges cannot be atomic on this platform.

ktbyers commented 7 years ago

@jedelman8 @itdependsnetworks

jedelman8 commented 7 years ago

Makes sense. This is actually how we do atomic changes with Ansible on nxos using the nxos_rollback and ntc_rollback modules. So yes, in agreement for merges: Step 1. Create a checkpoint file. Step 2: send commands. Step 3: rollback on error

On Wed, Mar 8, 2017 at 12:47 PM, Kirk Byers notifications@github.com wrote:

@jedelman8 https://github.com/jedelman8 @itdependsnetworks https://github.com/itdependsnetworks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/napalm-automation/napalm-nxos/issues/77#issuecomment-285113963, or mute the thread https://github.com/notifications/unsubscribe-auth/AGCgqkADVeM5Bmq5SO9uyJcxFpFXn3fVks5rjumcgaJpZM4MW7BF .

mirceaulinic commented 6 years ago

Moved to https://github.com/napalm-automation/napalm/issues/447