napalm-automation / napalm-salt

Modules for event-driven network automation and orchestration using Salt
Apache License 2.0
128 stars 36 forks source link

NTP module broken on EOS #16

Closed bewing closed 7 years ago

bewing commented 7 years ago

Attempting to set NTP servers on EOS results in a failed state due to mismatched template names:

root@saltmaster:~/napalm-salt/napalm# salt veos1 state.sls router.ntp
veos1:
----------
          ID: cf_ntp
    Function: netntp.managed
      Result: False
     Comment: Cannot set NTP servers: Cannot execute "load_template" on veos1 as bewing. Reason: Config template set_ntp_servers.j2 is not defined under /usr/local/lib/python2.7/dist-packages/napalm_eos/templates!
              Configuration discarded.
     Started: 13:13:43.103899
    Duration: 391.778 ms
     Changes:
              ----------
              servers:
                  ----------
                  added:
                      - 192.168.0.1

Summary for veos1
------------
Succeeded: 0 (changed=1)
Failed:    1
------------
Total states run:     1
Total run time: 391.778 ms
ERROR: Minions returned with non-zero exit code

Note that the template files are named set|delete_ntp_peers.j2, not set|delete_ntp_servers.j2. Not sure if it's incorrect in napalm-eos or what

Environment:

root@saltmaster:~/napalm-salt/napalm# pip freeze | grep napalm 2>/dev/null
napalm==1.1.0
napalm-base==0.20.4
napalm-eos==0.5.0
napalm-fortios==0.3.0
napalm-ibm==0.1.6
napalm-ios==0.4.0
napalm-iosxr==0.4.0
napalm-junos==0.4.4
napalm-nxos==0.4.1
napalm-panos==0.2.1
napalm-pluribus==0.4.2
veos1#show version
Arista vEOS
Hardware version:
Serial number:
System MAC address:  0015.5d1b.dbcf

Software image version: 4.16.6M
Architecture:           i386
Internal build version: 4.16.6M-3205780.4166M
Internal build ID:      e796e94c-ba3b-4355-afcf-ef0abfbfaee3

Uptime:                 4 days, 5 hours and 50 minutes
Total memory:           1897592 kB
Free memory:            353672 kB
mirceaulinic commented 7 years ago

To be fixed in napalm-eos 0.5.1