search

napalm-automation / napalm-yang

Bindings for napalm based on YANG models
Apache License 2.0
54 stars 44 forks source link

OSPF parser for Junos #146

Closed ckishimo closed 6 years ago

ckishimo commented 6 years ago

@dbarrosop reopening as requested. Thanks

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.08%) to 84.147% when pulling 8d1a094061cc6b7d42ead3a3b3f1811a835777f5 on ckishimo:ospfv2 into 75f22a57373409eb7fa2d80c6e0fc532350f62b9 on napalm-automation:develop.

ckishimo commented 6 years ago

@dbarrosop do not merge! despite passing the tests, I made a mistake and lost the data in the tests... I need to review it. Sorry for that

dbarrosop commented 6 years ago

ok ,ping me when this is ready for review :)

ckishimo commented 6 years ago

now I understand... I only implemented the parser. However for the tests the translator is needed as well :sweat_smile: I'll try but it may take a while...

ckishimo commented 6 years ago

@dbarrosop Please have a look... Note I had to remove from the tests the OSPF authentication as the OC model only supports authentication-type and not the key. Thanks

dbarrosop commented 6 years ago

Awesome work, just had a tiny comment :)