napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

Fix issue with github CI #104

Closed haesleinhuepf closed 2 years ago

haesleinhuepf commented 2 years ago

Hi all,

I'm suggesting to change this line in the napari plugin template, because it causes the following error in the github CI of likely all napari plugins:

Run git clone --depth 1 git://github.com/pyvista/gl-ci-helpers.git
Cloning into 'gl-ci-helpers'...
fatal: remote error: 
  The unauthenticated git protocol on port 941[8](https://github.com/haesleinhuepf/napari-workflows/runs/5616765422?check_suite_focus=true#step:5:8) is no longer supported.
Please see https://github.blog/2021-0[9](https://github.com/haesleinhuepf/napari-workflows/runs/5616765422?check_suite_focus=true#step:5:9)-01-improving-git-protocol-security-github/ for more information.
gl-ci-helpers/appveyor/install_opengl.ps1 : The term 'gl-ci-helpers/appveyor/install_opengl.ps1' is not recognized as 
the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was 
included, verify that the path is correct and try again.
At line:1 char:1
+ gl-ci-helpers/appveyor/install_opengl.ps1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (gl-ci-helpers/a...tall_opengl.ps1:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Credits to @jo-mueller for pointing out the solution. See:

Best, Robert

tlambert03 commented 2 years ago

Btw, more context for those curious:

https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git

And

https://stackoverflow.com/questions/70663523/the-unauthenticated-git-protocol-on-port-9418-is-no-longer-supported