search

napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

Fix make_sample_data return value #123

Closed mstabrin closed 2 years ago

mstabrin commented 2 years ago

I just did a plugin installation via cookiecutter, but loading the sample data lead to:

TypeError: ViewerModel._add_layer_from_data() takes from 2 to 4 positional arguments but 513 were given

I checked the code here: https://github.com/napari/napari/blob/main/napari/plugins/_skimage_data.py

and adapted the make_sample_data return values accordingly.

mstabrin commented 2 years ago

Are those failing tests related to my change?

Czaki commented 2 years ago

Looks unrelated. Also visible on main branch.

https://github.com/hackebrot/pytest-cookies/issues/62

mstabrin commented 2 years ago

@Czaki Do you think we can merge the fix or should we wait for the windows tests to pass again?

tlambert03 commented 2 years ago

thanks @mstabrin, LGTM