search

napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
69 stars 41 forks source link

Update isort version in pre-commit config #151

Closed aganders3 closed 1 year ago

aganders3 commented 1 year ago

The previous version was failing to install due to some issues with poetry. See https://github.com/PyCQA/isort/pull/2078.

aganders3 commented 1 year ago

Then again, now that napari is using ruff for this, perhaps that should be used in the plugin cookiecutter as well.

N.B. @Czaki

Czaki commented 1 year ago

I'm not sure as ruff is really fast in development and adding new rules.

I'm not against but it will require to preciselly preselect enabled rules and revisit it time to time.

aganders3 commented 1 year ago

Thanks for the input. I can see it both ways. On one hand pre-commit is basically pinning a version, so the fast changes shouldn't be a problem. On the other, I think we can expect many to use pre-commit autoupdate.

Czaki commented 1 year ago

at this moment, I prefer to switch to ruff with removing flake and isort. It provides a much better user experience.

aganders3 commented 1 year ago

Sounds good - I will close this then!